-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary Qt 6.5 support #26
Conversation
0f0fb05
to
d083405
Compare
I will also disable Qt6 to not spend too much time on build system changes during the reorganisation and iOS+Windows CI temporarily as they are slow. |
@ntadej Thank you very much for your work! I am super happy that this wonderful project makes the step toward Qt6.5. |
Ping @louwers again 😊 |
Using QtCreator + Qt 6.5.0 on Windows give the following error: get_target_property() called with non-existent target
"Qt6::QGeoServiceProviderFactoryMapLibreGLPlugin".
Call Stack (most recent call first):
CMakeLists.txt:38 (qt_internal_add_plugin) Perhaps somebody knows already what is wrong and saves me a lot of time? :) |
There's a Qt bug where they hardcode some things in their internal CMake. My goal is to try to move away from internal Qt CMake functions, but it will make the library slightly harder to either develop or use 😊 I don't have my installation at hand, but the function is called something like "qt target aliases", where they hardcode Qt6 somewhere, which should be changed to something like |
Hmmm.... but in my case, it shouldn't matter. I use Qt 6 :) And besides that, it doesn't seem to be hard-coded. At least not anymore:
|
I remember now, |
A, yes, of course! Didn't spot that. Using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, yes. It compiles and runs correctly and this change looks good.
I see that you have removed parameter support totally. So it's not even needed for Qt 5?
My idea is to have a consistent API between Qt5 and Qt6 (as much as Qt allows). My app is still Qt5 on some platforms (Windows for example). |
Preliminary Qt 6.5 support. This temporarily removes custom parameters feature as it has been removed from upstream Qt release.
Some additional API fixes are done based on the feedback from the Qt community.
A disclaimer is added to README as things will be moving around a bit in the next weeks.